Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MessageSelectMenu): droppybois #5692

Merged
merged 27 commits into from
Jun 24, 2021
Merged

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented May 28, 2021

Select Menus are still in private beta. This PR will not function if you do not have access.

Changelog

  • New class MessageSelectMenu
  • New types MessageSelectMenuOptions, MessageSelectOption, MessageSelectOptionData
  • New utility method resolvePartialEmoji for resolving emoji without a Client
  • Improved emoji resolving in MessageButton, also applied to MessageSelectOption (fixes MessageButton#emoji throws invalid form body error #5753)
  • Improved consistency of documentation across all component classes

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

@KuryKat KuryKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great changes, it will be great to be able to use it soon! :D👍

@iCrawl iCrawl merged commit e5fcf0b into discordjs:master Jun 24, 2021
@monbrey monbrey deleted the droppybois branch June 24, 2021 21:31
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
@bleuthoot-sven
Copy link

Looks like Selection Menus have been added to the documentation. I assume they have been released now:

https://discord.com/developers/docs/interactions/message-components#select-menus

@advaith1
Copy link
Contributor

advaith1 commented Jul 1, 2021

yes, it was announced yesterday:

image

@monbrey
Copy link
Member Author

monbrey commented Jul 2, 2021

This was also merged over a week ago so not sure why it matters to this PR that docs were released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageButton#emoji throws invalid form body error Request for adding support for message components